Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question about vq-vae reconstruction loss #48

Open
pangwong opened this issue Jul 27, 2023 · 0 comments
Open

question about vq-vae reconstruction loss #48

pangwong opened this issue Jul 27, 2023 · 0 comments

Comments

@pangwong
Copy link

Hi, I found the velocity calculation in the forward_vel function in losses.py may not use the correct features

def forward_vel(self, motion_pred, motion_gt) : 
    loss = self.Loss(motion_pred[..., 4 : (self.nb_joints - 1) * 3 + 4], motion_gt[..., 4 : (self.nb_joints - 1) * 3 + 4])
    return loss

in the code the data slice is [4:(self.nb_joints - 1) * 3 + 4], which should be rotation independent positions, not the velocity
did I miss something ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant