Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weather refactoring #1488

Merged
merged 35 commits into from
Dec 28, 2018
Merged

Weather refactoring #1488

merged 35 commits into from
Dec 28, 2018

Conversation

fewieden
Copy link
Contributor

  • Fixed openweathermap
  • Fixed darksky
  • Implemented forecast for both
  • added indoor values
  • documentation
  • ...

current
forecast

MichMich and others added 30 commits September 21, 2017 16:38
@MichMich
A first setup of the new Weather Module
ef17259
@nhubbard
Add Dark Sky Module
7f2e643
@nhubbard
Fix Indentation?
2bf18d8
@MichMich
Add readme.
5b1462a
@MichMich
First implementation of the currentWeatherView
7131112
@MichMich
Add a small forecast example.
ff9c6ba
@nhubbard
Merge branch 'weather-refactor' of https://github.com/MichMich/MagicM…
7be6031 
…irror into weather-refactor
@nhubbard
Update fork
837e275
@nhubbard
Revert "Fix Indentation?"
cd129fb 
This reverts commit 2bf18d8.
@MichMich
Merge branch 'develop' into weather-refactor
3fa810b
@MichMich
Use templates to render weather.
99e3a47
@MichMich
Fix lint errors.
ad240cf
@MichMich
Add Darksky provider.
681a845
@MichMich
Minor changes.
0776dfc
@MichMich
Merge branch 'develop' into weather-refactor
d567fd4
@MichMich
Merge branch 'develop' into weather-refactor
ec2169e
@MichMich
Set temperature rounding.
241ff5c
@MichMich
Make all visiable values dynamic.
ab732b5
@MichMich
Merge branch 'develop' into weather-refactor
995296e
@MichMich
Rename templates to .njk files to allow syntax highlighting.
a79e1b6
@MichMich
Show unit.
22a50b7
@MichMich
Show humidity.
16c8878
@MichMich
Remove todo item.
07d35a8
@fewieden
fix moment, add unit filter
91ddc00
@fewieden
start with forecast template
3341c9e
@fewieden
show indoor data, add loading message
66ceafd
@fewieden
indoor data, new filter, small cleanup
0fe79b5
@fewieden
weatherprovider
6383618
@fewieden
small improvements
ebee80d
@fewieden
forecast
95adc0a
@fewieden fewieden mentioned this pull request Dec 27, 2018
Closed
@fewieden
Copy link
Contributor Author

Some things are still missing:

  • feels like temperature
  • openweathermap forecast for newer api keys (grouping 3h forecasts)
  • darksky unit handling
  • some more config options from the previous modules

But I would categorize those more as improvements.

@fewieden
Copy link
Contributor Author

The build on travis only failed for 50%. Nodejs can't handle class and in the other one the before hooks timed out as seen previously

@MichMich
Copy link
Collaborator

SUPER AWESOME WORK! 🎉

If we can find a way to make travis happy, I can merge it, and then merge it into develop so we can shift the module as EXPERIMENTAL, which will hopefully increase traction in the development.

I'll be releasing the next MM version January 1st, so lets try to get it included in this version! :)

@fewieden fewieden changed the base branch from weather-refactor to develop December 27, 2018 22:04
@MagicMirrorBot
Copy link

Warnings
⚠️

Please include an updated CHANGELOG.md file.
This way we can keep track of all the contributions.

Generated by 🚫 dangerJS

@fewieden
Copy link
Contributor Author

@MichMich I merged current develop branch (has an updated travis config) into the weather branch. It passed now.

@MichMich MichMich merged commit b94dc50 into MagicMirrorOrg:develop Dec 28, 2018
@MichMich
Copy link
Collaborator

Great work! Ill make sure to merge it into dev before releasing a new version.

@fewieden fewieden mentioned this pull request Jan 5, 2019
Merged
@fewieden fewieden deleted the weather branch February 10, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fewieden @MichMich @MagicMirrorBot @nhubbard