Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tips for list where only 5000 items are displayed #785

Open
poor-defined opened this issue Sep 9, 2024 · 4 comments
Open

Add tips for list where only 5000 items are displayed #785

poor-defined opened this issue Sep 9, 2024 · 4 comments
Assignees
Labels

Comments

@poor-defined
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Sometimes, there are lots of data in a list, however we should only display maximum limit of them, like 5000 items to reduce the load of our service.

Image

Describe the solution you'd like
In this case, we should show the tips to users to inform them there're only limited items in this list.

Additional context
UI link

@zmcNotafraid
Copy link
Member

zmcNotafraid commented Dec 17, 2024

  • /api/v1/address_transactions/:id returns total_page , use this as paginator's total_page, don't use total_count to calculate anymore.Also set max returns 5000 records
  • /api/v2/scripts/:id/ckb_transactions set max returns 5000 records
  • /api/v2/scripts/:id/referring_cells set max returns 5000 records

@zmcNotafraid
Copy link
Member

@zmcNotafraid zmcNotafraid moved this from 🏗 In Progress to 👀 Testing in CKB Explorer Jan 7, 2025
@FrederLu
Copy link

FrederLu commented Jan 7, 2025

https://ckb-explorer-frontend-in-magickbase-repo-git-832df1-magickbase.vercel.app/en/script/0x25c29dc317811a6f6f3985a7a9ebc4838bd388d19d0feeecf0bcd60f6c0975bb/type/referring_cells?page=1&size=10
image

1、It is found that the data displayed by Referring Cells through paging is inconsistent with the statistical data. If the 5000 data is changed to be displayed here, it is best to have a prompt message similar to the Transactions tab.


https://ckb-explorer-frontend-in-magickbase-repo-git-832df1-magickbase.vercel.app/address/ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsq0dnd72kh63g08574r38qkyph2ewl9ummcfp6znk
image

2、It is best for the prompt information here to directly prompt and display the specific number of transaction data without prompting for paging information.
@PainterPuppets

@FrederLu
Copy link

https://ckb-explorer-frontend-in-magickbase-repo-git-832df1-magickbase.vercel.app/en/script/0x25c29dc317811a6f6f3985a7a9ebc4838bd388d19d0feeecf0bcd60f6c0975bb/type/referring_cells?page=1&size=10 image

1、It is found that the data displayed by Referring Cells through paging is inconsistent with the statistical data. If the 5000 data is changed to be displayed here, it is best to have a prompt message similar to the Transactions tab.

https://ckb-explorer-frontend-in-magickbase-repo-git-832df1-magickbase.vercel.app/address/ckt1qzda0cr08m85hc8jlnfp3zer7xulejywt49kt2rr0vthywaa50xwsq0dnd72kh63g08574r38qkyph2ewl9ummcfp6znk image

2、It is best for the prompt information here to directly prompt and display the specific number of transaction data without prompting for paging information. @PainterPuppets

This comment problem still exists, please confirm. @PainterPuppets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 👀 Testing
Development

No branches or pull requests

5 participants