Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Categories" seems to be buggy #432

Open
matt-nervos opened this issue Feb 16, 2024 · 3 comments
Open

"Categories" seems to be buggy #432

matt-nervos opened this issue Feb 16, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@matt-nervos
Copy link
Contributor

matt-nervos commented Feb 16, 2024

when clicking on a "Category" value, it takes a few seconds for the page to respond and the entries that are shown don't seem to correspond to the Category that was clicked

image image
@Keith-CY Keith-CY added the bug Something isn't working label Feb 18, 2024
@WhiteMinds
Copy link
Contributor

when clicking on a "Category" value, it takes a few seconds for the page to respond

I can optimize this issue, but the URL will undergo some changes, transitioning from https://www.nervos.org/knowledge-base?sort_by=state&page=2 to https://www.nervos.org/knowledge-base/view/state/2.

the entries that are shown don't seem to correspond to the Category that was clicked

It looks like this feature is working fine here.

What exactly is incorrect? Do you want Popular Posts to be sorted by category based on clicks as well?

image

@matt-nervos
Copy link
Contributor Author

thanks @Keith-CY is the URL change impact only cosmetic? I don't see any other effects, seems ok

Regarding the tag-click behavior, as a user, when I click the tag, I expect only articles related to that tag to show. Instead of "filter" it seems the behavior is "sort", so it shows articles related to the tag first, but then all other articles. This is confusing to a user, as they may think all of these articles are related to the tag they clicked

image

@WhiteMinds
Copy link
Contributor

PR: #435

This PR changes the list page to static generation to improve access speed, and as a result, changes the URL format to /knowledge-base/list/$opts/$page.

Regarding the tag-click behavior, as a user, when I click the tag, I expect only articles related to that tag to show. Instead of "filter" it seems the behavior is "sort", so it shows articles related to the tag first, but then all other articles. This is confusing to a user, as they may think all of these articles are related to the tag they clicked

@matt-nervos Do we want to add an additional filtering feature?

If we directly replace the old sorting function with a filtering function, the functionality of sorting by Newest Post, Oldest Post will also be removed.

This requires PM involvement in the discussion, and if it is a new feature, we also need the designer to provide a design draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants