Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dynamic fee rate based on fee_rate_statistics #95

Closed
Keith-CY opened this issue Jan 12, 2023 · 5 comments
Closed

Implement dynamic fee rate based on fee_rate_statistics #95

Keith-CY opened this issue Jan 12, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@Keith-CY
Copy link
Member

PRD: #87
UI: Magickbase/visual-style-guide#21

@alexsupa597
Copy link

PR: nervosnetwork/neuron#2587

@alexsupa597
Copy link

alexsupa597 commented Feb 21, 2023

@Keith-CY @Kirl70 To confirm, I think the countdown of this place is misplaced. It should be in the tab of custom price, right?

PS: should the price in the dropdown also need update based on the data from the server? If so, I want to know how can I compute the total fee we should pay.
image

https://www.figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=319%3A4539&t=CWzeBjkusAhZL7SX-0

@Keith-CY
Copy link
Member Author

@Keith-CY @Kirl70 To confirm, I think the countdown of this place is misplaced. It should be in the tab of custom price, right?

The countdown should be placed with the pre-defined 3 gears of prices, these 3 gears update automatically.

When the custom price is active, the price is from what entered by users and won't update automatically

PS: should the price in the dropdown also need update based on the data from the server? If so, I want to know how can I compute the total fee we should pay. image

figma.com/file/6XNoimRDbFTTNm016rbIdU/Magickbase?node-id=319%3A4539&t=CWzeBjkusAhZL7SX-0

The fee changes along with the price. fee = tx_size * price, the tx_size could be get from a serialized transaction, ref: https://github.com/nervosnetwork/neuron/blob/ce2c08f00269aba13979853a38cb72ae42b12b6a/packages/neuron-wallet/src/services/transaction-sender.ts#L709

When the tx is invalid, it cannot be serialized, and the fee is 0 or -(better to confirm with @Danie0918)

@alexsupa597
Copy link

The new PR is here: nervosnetwork/neuron#2599

@Danie0918 Danie0918 moved this from 🏗 In Progress to 👀 Testing in Neuron Mar 6, 2023
@Danie0918 Danie0918 assigned yanguoyu and Cedar67 and unassigned alexsupa597 Mar 6, 2023
@Cedar67
Copy link

Cedar67 commented Mar 26, 2023

The new PR is here: nervosnetwork/neuron#2599

Custom prices and unit prices are only displayed in Simplified Chinese, and cannot be switched to English or Traditional Chinese.

image

@Danie0918 Danie0918 moved this from 👀 Testing to 🚩Pre Release in Neuron Apr 17, 2023
@github-project-automation github-project-automation bot moved this from 🚩Pre Release to ✅ Done in Neuron Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Status: In Progress
Development

No branches or pull requests

4 participants