Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: velocity input is not in SI units #189

Open
ThomasCeulemans opened this issue Apr 6, 2023 · 0 comments
Open

API: velocity input is not in SI units #189

ThomasCeulemans opened this issue Apr 6, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@ThomasCeulemans
Copy link
Collaborator

When inputting data into magritte models, we assume SI units for most data, which is fine. However, for the velocities, we demand them normalized compared to the speed of light (this is for convenience the formulae).
We should think about (a) either changing the api (not fully recommend, a this breaks existing code) or (b) implementing an alternative api in which we demand the units of all inputs (using astropy units for example).

@ThomasCeulemans ThomasCeulemans added the enhancement New feature or request label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant