Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper Windows 10 style #3508

Closed
Symbai opened this issue May 26, 2019 · 9 comments
Closed

Proper Windows 10 style #3508

Symbai opened this issue May 26, 2019 · 9 comments

Comments

@Symbai
Copy link

Symbai commented May 26, 2019

Could we get a proper Windows 10 style please? Starting by fixing the checkbox style (requested more than two years ago, reported a couple of times by different people) over to a fluent style? It currently doesn't really fit into Windows 10 at all. And although a visual change was kinda announced two years ago, nothing have changed.

I'm sorry for being the one idiot mentioning it but I think that many people would really appreciate if the style can be updated to the current standard. I know this is a free time project and such, so please consider this as a "nice way to ask for it pretty please" in case it doesn't sound like that. Thank you.

@timunie
Copy link
Collaborator

timunie commented May 27, 2019

@Symbai you're not allone, i am waiting with you :-) . I think we have to be a bit more patient ;-).

See also #3328 , #3326 , #3136

@batzen
Copy link
Collaborator

batzen commented May 27, 2019

So you are already (at least) three (counting @Nuklon in) people who could take this as an opportunity to contribute to this open source project.
Looking forward to your PR (or PRs as it would probably be better to split this into multiple PRs).

@Symbai Symbai closed this as completed May 27, 2019
@batzen
Copy link
Collaborator

batzen commented May 28, 2019

@Symbai Why did you close this?

@Symbai
Copy link
Author

Symbai commented May 28, 2019

Because of the negative feedback

@gep13
Copy link

gep13 commented May 28, 2019

@Symbai any negative feedback you received is likely due to the way in which you phrased the problem that you are seeing. I know you say that you were trying to ask it nicely, but I, and obviously others didn’t think it came across that way.

A far better way to approach this would have been to ask “how can I help”, or “where would be a good place to start looking at testing/fixing this”?

Unless there is another issue in this repo specifically requesting this addition, I personally would suggest that it should be re-opened so that it can be tracked.

@timunie
Copy link
Collaborator

timunie commented May 28, 2019 via email

@gep13
Copy link

gep13 commented May 28, 2019

@timunie said...
So code produced by me might not reach the standard of MahApps. If there is a way for me to help, please let me know.

I can't speak for @punker76 but I would say, based on my experience with working with him in Open Source, that he would be more than willing to provide guidance on any PR that is raised in this repository. If you are not sure about something, perhaps start the PR, and then ask questions on the lines that you are not sure on. Then @punker76 and other contributors to the project will be able to advice.

While I am not able to contribute to this project, I am a consumer of it, and I choose to support the project through Open Collective which is another way to support the project.

@Symbai
Copy link
Author

Symbai commented May 28, 2019

The owner is welcome to reopen the issue if he like but I don't since I don't like to open a ticket requesting on something that isn't really accepted by the majority. I've taken the feedback as an answer on my question and therefore closed the request as I believe there is no value in it. Thanks for considering it though.

@batzen
Copy link
Collaborator

batzen commented May 28, 2019

My feedback wasn't meant negative. But as you noticed yourself work on this hasn't started for a long time and there are already open issues for this. So if you want work to start on this you can just go ahead and start the work.
So my feedback was meant to point out "if you want something to be done, do it yourself", but not in a negative way.
If you need help, guidance, advice or something like that feel free to mention me and I'll try to help as much as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants