Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorPicker Control #3520

Closed
timunie opened this issue Jun 4, 2019 · 3 comments · Fixed by #3930
Closed

ColorPicker Control #3520

timunie opened this issue Jun 4, 2019 · 3 comments · Fixed by #3930
Milestone

Comments

@timunie
Copy link
Collaborator

timunie commented Jun 4, 2019

Is your feature request related to a problem? Please describe.
I wanted to give my users the option to hava a custom accent color. My result is a custom class for now, but may be someday it will be implemented for others, too. ( see #3515 ). I think it would be nice to have a colorpicker, as there is none in WPF by default

Describe the solution you'd like
have a colorpicker for selecting colors

Additional context
There are several ideas what we can do:

Closed Issues
None

@punker76 I would like to help with this topic, if you want me to. If you don't want to have a colorpicker at all, just close this issue. I wont blame you.

@RejectKid
Copy link

It'd be cool to have this inside of the mahapps kit imo. Currently I'm using

https://github.com/Dirkster99/ColorPickerLib

but it'd be nice to have them in one place. maybe could use his colorPicker as a starting point?

@timunie
Copy link
Collaborator Author

timunie commented Aug 1, 2019

@RejectKid this control is based on this toolkit, as far as I can see. There are a few resons why I am trying to implement it on my own:

  • Localization only shows when the Control is active, I want it shown all the time
  • The control is hard to style imo
  • what about the license? Can we use it without any permission?
  • it is sometimes slow when having many colors
  • the list of available colors is static, so if you want to provide different ColorPickers for different proposes you need to workaround this.

I still need some time to get this working and @punker76 has more important stuff to do, so we need to be a bit patient at the moment

current state:
image

Happy coding
Tim

@timunie
Copy link
Collaborator Author

timunie commented Aug 6, 2019

Update:
image

If someone is interested, here is my code:
https://github.com/timunie/MahApps.Metro/tree/ColorPicker

Any feedback is welcome.

Happy coding
Tim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

3 participants