Add get_pipeline_cache_data #166
Conversation
|
I think we should just return a
I am not sure when you would want to only partially retrieve the pipeline cache. @Ralith Any thoughts? |
|
@MaikKlein I have updated the PR according to your advice. I can squash the commits if you want. |
ash/src/device.rs
Outdated
| pipeline_cache: vk::PipelineCache, | ||
| ) -> VkResult<Vec<u8>> { | ||
| let data_size: *mut usize = mem::uninitialized(); | ||
| let data: *mut c_void = mem::uninitialized(); |
There was a problem hiding this comment.
I think you should initialize them explicitly to a null ptr.
ash/src/device.rs
Outdated
| ); | ||
|
|
||
| match err_code { | ||
| vk::Result::SUCCESS => Ok(Vec::from_raw_parts(data as _, *data_size, *data_size)), |
There was a problem hiding this comment.
You have to allocate the buffer to data yourself. You can do this with Vec::with_capacity and set_len. And you need to call get_pipeline_cache_data two times to get the size, and then to fill the buffer.
ash/src/device.rs
Outdated
| @@ -1281,27 +1281,25 @@ pub trait DeviceV1_0 { | |||
| pipeline_cache: vk::PipelineCache, | |||
| ) -> VkResult<Vec<u8>> { | |||
| let data_size: *mut usize = ptr::null_mut(); | |||
There was a problem hiding this comment.
Sorry I overlooked that the first time. You probably want to allocate that on the stack like let mut data_size = 0 and then write to it with &mut data_size
zakorgy
force-pushed
the
get-pipeline-cache
branch
from
36c6037
to
fa83016
Compare
|
@MaikKlein any chance of releasing a version with this? |
|
@kvark Oh I can't believe I haven't pushed a new version. I fix up a few PRs and I publish a new version later today. |
This change is