Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test with headless chrome #20

Merged
merged 5 commits into from
Feb 5, 2018
Merged

test with headless chrome #20

merged 5 commits into from
Feb 5, 2018

Conversation

marcoow
Copy link
Member

@marcoow marcoow commented Jan 5, 2018

No description provided.

@marcoow marcoow requested a review from jayjayjpg January 5, 2018 12:46
@marcoow marcoow mentioned this pull request Jan 5, 2018
Merged
jayjayjpg
jayjayjpg reviewed Jan 5, 2018
View reviewed changes
Copy link
Contributor

@jayjayjpg jayjayjpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good so far, only the tests seem to be failing for older ember try scenarios - should this be fixed beforehand?

@marcoow
Copy link
Member Author

marcoow commented Jan 5, 2018

I guess @Turbo87 is most familiar with this and should have a look after his vacation.

@marcoow marcoow requested a review from Turbo87 January 5, 2018 16:19
@Turbo87 Turbo87 mentioned this pull request Feb 2, 2018
Closed
@Turbo87 Turbo87 force-pushed the headless-chrome branch 2 times, most recently from 8de0ee5 to 6a78308 Compare February 5, 2018 11:00
@Turbo87 Turbo87 merged commit a391965 into master Feb 5, 2018
@Turbo87 Turbo87 deleted the headless-chrome branch February 5, 2018 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayjayjpg jayjayjpg jayjayjpg left review comments

@Turbo87 Turbo87 Awaiting requested review from Turbo87

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcoow @jayjayjpg @Turbo87