🐛 fix: ESP32 can get electricity value correctly

Hsun1031 · Hsun1031 · commit 6e9d02ae5157 · 2023-03-20T14:13:38.000+08:00
Closes #4 -Battery Test
diff --git a/src/components/module/battery.cpp b/src/components/module/battery.cpp
@@ -20,7 +20,6 @@ void setup_battery(Battery_conf *conf) {
  */
 uint8_t get_electricity() {
     uint16_t electricity = analogRead(_battery_conf->pin);
-    uint32_t batter_value = (_battery_conf->max - _battery_conf->min) * 100;
 
     if(electricity < _battery_conf->min) {
         return 0;
@@ -31,7 +30,7 @@ uint8_t get_electricity() {
     }
 
     // Scale the analog input value to a percentage between 0 and 100
-    return ( (electricity - _battery_conf->min) / batter_value );
+    return ( ( (electricity - _battery_conf->min) * 100 ) / (_battery_conf->max - _battery_conf->min) );
 }
 
 uint16_t get_electricity_value() {

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,6 @@ void setup_battery(Battery_conf *conf) {`
`20`	`20`	`*/`
`21`	`21`	`uint8_t get_electricity() {`
`22`	`22`	`uint16_t electricity = analogRead(_battery_conf->pin);`
`23`		`- uint32_t batter_value = (_battery_conf->max - _battery_conf->min) * 100;`
`24`	`23`
`25`	`24`	`if(electricity < _battery_conf->min) {`
`26`	`25`	`return 0;`
`@@ -31,7 +30,7 @@ uint8_t get_electricity() {`
`31`	`30`	`}`
`32`	`31`
`33`	`32`	`// Scale the analog input value to a percentage between 0 and 100`
`34`		`- return ( (electricity - _battery_conf->min) / batter_value );`
	`33`	`+ return ( ( (electricity - _battery_conf->min) * 100 ) / (_battery_conf->max - _battery_conf->min) );`
`35`	`34`	`}`
`36`	`35`
`37`	`36`	`uint16_t get_electricity_value() {`