🐛 fix: ESP32 can get electricity value correctly

Closes #4 -Battery Test
MakerbaseMoon · Mar 20, 2023 · 6e9d02a · 6e9d02a
1 parent 898735d
commit 6e9d02a
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/src/components/module/battery.cpp b/src/components/module/battery.cpp
@@ -20,7 +20,6 @@ void setup_battery(Battery_conf *conf) {
  */
 uint8_t get_electricity() {
     uint16_t electricity = analogRead(_battery_conf->pin);
-    uint32_t batter_value = (_battery_conf->max - _battery_conf->min) * 100;
 
     if(electricity < _battery_conf->min) {
         return 0;
@@ -31,7 +30,7 @@ uint8_t get_electricity() {
     }
 
     // Scale the analog input value to a percentage between 0 and 100
-    return ( (electricity - _battery_conf->min) / batter_value );
+    return ( ( (electricity - _battery_conf->min) * 100 ) / (_battery_conf->max - _battery_conf->min) );
 }
 
 uint16_t get_electricity_value() {