Deprecation of DiscreteSurface is broken

[haakon-e]

On Makie v0.21.11 I can define methods that dispatch on Makie.DiscreteSurface

julia> f(::Makie.DiscreteSurface) = 1
f (generic function with 1 method)

however on Makie v0.21.12 I get the following error:

julia> f(::Makie.DiscreteSurface) = 1
ERROR: ArgumentError: invalid type for argument number 1 in method definition for f at REPL[9]:1
Stacktrace:
 [1] top-level scope
   @ REPL[9]:1

I suspect this comes from #4333, which deletes

Makie.jl/src/deprecated.jl

Lines 4 to 5 in 65a7181

	Base.@deprecate_binding DiscreteSurface CellGrid true
	Base.@deprecate_binding ContinuousSurface VertexGrid true

and replaces it with

Makie.jl/src/deprecated.jl

Lines 5 to 13 in b971fbb

	function DiscreteSurface(args...; kwargs...)
	@warn "Makie.DiscreteSurface() is deprecated, use Makie.CellGrid() instead" maxlog=1
	CellGrid(args...; kwargs...)
	end
	function ContinuousSurface(args...; kwargs...)
	@warn "Makie.ContinuousSurface() is deprecated, use Makie.VertexGrid() instead" maxlog=1
	VertexGrid(args...; kwargs...)
	end

so that DiscreteSurface is no longer recognized as a DataType, but instead is a Function.

---

• what version of Makie are you running? (]st -m Makie) 0.21.12
• can you reproduce the bug with a fresh environment ? (]activate --temp; add Makie)
• What platform + GPU are you on? Mac M1

[SimonDanisch]

Hm, Yeah I guess that's the disadvantage of that approach.
We could make it a type as well, or say this has been breaking for multiple versions, so it's fine to leave it broken.

[haakon-e]

[...] or say this has been breaking for multiple versions, so it's fine to leave it broken.

What do you mean by this? 0.21.12 was released two days ago, so "breaking for multiple versions" doesn't seem accurate; or do you mean it has been deprecated for multiple versions?

[ffreyer]

DiscreteSurface has been deprecated for ~10 months now, since version 0.20