Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marathon annotation filtering being ignored #111

Closed
msd117c opened this issue Mar 6, 2024 · 3 comments
Closed

Marathon annotation filtering being ignored #111

msd117c opened this issue Mar 6, 2024 · 3 comments

Comments

@msd117c
Copy link

msd117c commented Mar 6, 2024

Describe the bug
After bumping the dependency to 0.5.4 the blocklist with annotation type stopped working.

To Reproduce
Add blocklist filtering option with annotation as type:

...
filteringConfiguration:
  blocklist:
    - type: "annotation"
      values:
        - "com.example.Annotation"

Expected behavior
The annotated test classes should be ignored.

Android device:

  • Device: [Nexus 5X]
  • API: [33]
  • Adam Version [0.5.4]
  • Android Debug Server Version [41]

Additional context
It was working on 0.5.3.

@Malinskiy
Copy link
Owner

There was a breaking change in the protocol for annotations, you need to wait for the new release of marathon or build from develop.
Which version of marathon are you currently using?

And why are you submitting issues for marathon to this repository?

@msd117c
Copy link
Author

msd117c commented Mar 7, 2024

I see, I'm using 0.9.1 for Marathon.

As the dependency is not mandatory in that framework I reported the issue here, sorry for the noise.

@msd117c msd117c closed this as completed Mar 7, 2024
@Malinskiy
Copy link
Owner

Marathon 0.9.1 depends on 0.5.3 https://github.com/MarathonLabs/marathon/blob/c6465a8c6563bb731a063f5ee40940543caec63d/buildSrc/src/main/kotlin/Versions.kt#L9, so I understand you want to go bleeding edge with your dependencies but only the maintainer of a project can guarantee it's working. In this case, adam has nothing to do with the fact that Marathon needs to support a new protocol version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants