Some downloaded files are named None

[thany]

Discussed in #341

I hope it's okay to make this into a bug. It keeps happening, so I really think it's a bug. Since the media_id suggests an identifier, it sort of has to be there, or how on good mother earth could it ever identify the media in the first place, and download it?

At the very very least an identifier could be a url. But either way it's got to be something, right?

^{Originally posted by thany May 4, 2023}
My config looks like this:

So it should be that media_id is always used for filenames. I've checked, and this setting doesn't appear to be overridden somewhere. Unless I'm missing something.

Some files are downloaded and named None 1.jpg, None 2.jpg, etc. This conflicts when I end up moving files around, merging a downloaded set with previous downloads, and so on. Such generic names are just not brilliant to deal with. This happens enough to be a nuisance. Say, about 1% of files is like that. I don't know which files they are, because there's no ID to refer back to...

But why is this being done? Surely there is always a media_id associated with media, or how could it be there? If Reddit somehow manages to return ID-less media in its responses, can DFR please use a different ID for such files that is still unique? Is there currently a way to set that up?

Maybe we can start by figuring about which condition(s) need to be in effect in order for DFR to decide to go with None, and work from there. Unless that is, there's already a good solution/workaround for this problem.