Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubeclient next: tracker of non backward compatible issues #199

Closed
moolitayer opened this issue Oct 5, 2016 · 11 comments
Closed

Kubeclient next: tracker of non backward compatible issues #199

moolitayer opened this issue Oct 5, 2016 · 11 comments

Comments

@moolitayer
Copy link
Collaborator

@grosser
Copy link
Contributor

grosser commented Nov 7, 2016

@cben
Copy link
Collaborator

cben commented Mar 28, 2017

#240 probably (start or stop always wrapping SSL errors — either one may break code expecting current behavior, though current behavior is inconsistent.)

@abonas
Copy link
Member

abonas commented Mar 29, 2017

@moolitayer have you considered tracking backward incompatible issues by labeling them directly as such? tracking them here is nice, but manual tracking is fragile and some things can slip away

@moolitayer
Copy link
Collaborator Author

@abonas sounds great. Note I cannot label stuff ATM

@abonas
Copy link
Member

abonas commented Mar 29, 2017

@abonas sounds great. Note I cannot label stuff ATM

@moolitayer do you mean you cannot create new labels or you can't apply existing labels? I think you should be able to label things. Please check. I can create a new label, any preferred name?

@moolitayer
Copy link
Collaborator Author

As a non administrator (is that how it is called) I cannot assign labels. I think that why we label things using the bot in miq?

kubeclient next tracker of non backward compatible issues issue 199 abonas kubeclient

@abonas
Copy link
Member

abonas commented Mar 29, 2017

@moolitayer I believe that you're right. I can create a new label and assign to the relevant issues. How would you like this label to be called?

@moolitayer
Copy link
Collaborator Author

api change ?

@abonas
Copy link
Member

abonas commented Mar 29, 2017

api change ?

But backwards incompatible changes can be also non related to api change, so perhaps something more generic would be better

@moolitayer
Copy link
Collaborator Author

I sent PRs for the items mentioned here:

And some fixes:

I did not tackle #240 at this time. We need something to do for the next release ;)

@cben
Copy link
Collaborator

cben commented Jan 23, 2019

Out of date. Most already done. We've had a couple major releases since.
We have a couple outstand backward-incompatible changes, but tracking in issue like this doesn't scale, I'll use labels if needed.

@cben cben closed this as completed Jan 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants