-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to add api groups to existing client #348
Comments
Why not do something like
Or (because how often do you really switch)
Adding the possibility to add many groups IMHO creates unnecessary complexity. |
I think that's #347.
that's #346. Trying to keep one issue per approach to focus discussion :) EDIT: see #208 (comment) for bigger overview There's a convenience tradeoff — for many use cases you can |
Also worth mentioning I think we need #332 anyway.
which maybe makes some approaches like #347 less of a win (?) |
overview of alternatives: #208 (comment)
A variant of "union" client #208, #241:
Many people want one client object to combine methods from multiple API groups. The main questions are: union of what groups, which version per group, and who wins method name collisions?
This proposal is that Kubeclient would not try to guess. User would start from one group, and be able to add them one by one, each with specific version:
many people would add all desired groups when constructing client, and then just have the ability to call all methods:
Method name collisions would be decided by order of addition. Not sure if latest or earliest wins?
I think this can solve some concerns with #241.
It also can work better with CRDs that might appear dynamically, after client exists.
The text was updated successfully, but these errors were encountered: