You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
kubevirt has GET virtualmachineinstances/{name}/vnc Open a websocket connection to connect to VNC on the specified VirtualMachineInstance.
Conclusion?
So far, it sounds like generic discovery is pretty pointless, as one needs special-purpose code for each use case anyway? If anyone has counter-examples, please post here! That's my goal in opening this issue!
P.S. Method naming problem
One of the reason Kubeclient ignores sub-resource is it translates resources like pods to method names like get_pods, delete_pod etc. If we stop ignoring them, it's not obvious how to name methods.
The text was updated successfully, but these errors were encountered:
cc @shiramax. I believe your kubevirt VNC use case won't be helped by any generic sub-resource functionality, which this issue is about; but #417 (params to do your own connection) is more relevant for you.
Kubernetes APIs include many sub-resources.
Currently Kubeclient ignores all of those in discovery and surprisingly we haven't seen much complaints.
This is a pre-emptive issue to collect whether there are any use cases for generic discovery support?
The actual API of sub-resources varies widely, and you can't know this from the discovery info 🎁
Some sub-resources are pretty normal k8s CRUD, e.g. pods/{name}/status.
Some are wildly different:
Client#proxy_url
and the rest is your problem...Client#get_pod_log
covering most options.and API extensions (at least ones implemented with via API aggregation) can offer varying sub-resource semantics too:
Conclusion?
So far, it sounds like generic discovery is pretty pointless, as one needs special-purpose code for each use case anyway?
If anyone has counter-examples, please post here! That's my goal in opening this issue!
P.S. Method naming problem
One of the reason Kubeclient ignores sub-resource is it translates resources like
pods
to method names likeget_pods
,delete_pod
etc. If we stop ignoring them, it's not obvious how to name methods.The text was updated successfully, but these errors were encountered: