Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move service dialogs from core #46

Closed
durandom opened this issue Apr 12, 2017 · 7 comments
Closed

move service dialogs from core #46

durandom opened this issue Apr 12, 2017 · 7 comments
Assignees

Comments

@durandom
Copy link
Member

ManageIQ/manageiq#14668 has been merged. Now we can also seed content/service_dialogs. Looks like there is at least one for azure.

@djberg96 do you want to move this over here?

@djberg96
Copy link
Collaborator

@durandom I'll get a PR in today. What about orchestration_templates?

@durandom
Copy link
Member Author

@djberg96 cool.

I'll get a PR in today. What about orchestration_templates?

Dont know :) Are they seeded like the dialogs?

@djberg96
Copy link
Collaborator

@bdunne Do you know the answer to that?

@bdunne
Copy link
Member

bdunne commented Apr 25, 2017

Looks like seeding for that model needs to be updated for plugins as well. I would expect them to move to content/orchestration_templates/. cc @bzwei

@durandom
Copy link
Member Author

@djberg96 @bzwei do you want to have a look at that?
The dialog.rb and miq_dialog.rb do mostly the same.
Otherwise I'll do it.

@bzwei
Copy link
Contributor

bzwei commented Apr 25, 2017

@durandom Go ahead. Thanks!

@djberg96
Copy link
Collaborator

djberg96 commented May 3, 2017

Done!

@djberg96 djberg96 closed this as completed May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants