Relationship to all entities that are archivable should use an active context

[moolitayer]

I think these are:

• container.rb
• container_group.rb
• container_image.rb
• container_project.rb

See

• https://github.com/ManageIQ/manageiq/pull/15251/files#diff-055b42a9cb7c02e4d91fb07e80ca49fdR16
• https://github.com/ManageIQ/manageiq/pull/15251/files#diff-268a58d46a171293f40496890d650b72R5

cc @Ladas @cben @agrare

[cben]

and container_node.rb (EDIT: not yet, ManageIQ/manageiq#15351)

cc @zakiva @zeari
I agree we want active on the associations by default. But should be careful whether this changes meaning of any historical/chargeback reporting — might need to adjust those queries to still include archived objects.

[zeari]

meaning of any historical/chargeback reporting — might need to adjust those queries to still include archived objects.

@cben we use archived? so it should be fine. https://github.com/manageiq/manageiq/blob/master/app/models/chargeback_container_image.rb#L100

[Ladas]

Also the relations using :active should be the same as before, when the foreign key was nullified. In both cases, the relation did not return disconnected objects. So chargeback was usually using something else, like Model.where(...), instead of the associations.

[cben]

We're talking about entity–entity association here, not ems–entity. Those are not and were not nullified on disconnect (except image-registry), so AFAICT return both active and archived (example that started this: image.containers. container may be archived while image is still in use.) Chargeback: just asking `archived?` is not enough, if we add active scoping, you'll stop seeing archived ones; will need the both-kinds query to preserve behavior.

[zeari]

Chargeback: just asking archived? is not enough, if we add active scoping,
youll stop seeing archived ones; will need the both-kinds query to preserve
behavior.

We always take all Containers\projects into consideration regardless if theyre currently active or not.
archived? is used to show in the specific line of the report if the container\project is currently alive or not.

[cben]

leftover: the pod-project relation is disconnected but kept track of using old_container_project:
ContainerGroup belongs_to :old_container_project
ContainerProject has_many :archived_container_groups, :foreign_key => "old_container_project_id"

In the spirit of soft delete, should stop doing that, retain container group's container_project_id intact but put active scope on project.container_groups.
UPDATE: this got implemented by ManageIQ/manageiq#16302, but still need a data migration to restore already disconnected container_project_id from old_container_project_id.

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

[mfeifer]

Please re-open if this is still a bug.