Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When branching, drop the code coverage section in the ci.yaml #296

Open
jrafanie opened this issue Feb 27, 2024 · 0 comments
Open

When branching, drop the code coverage section in the ci.yaml #296

jrafanie opened this issue Feb 27, 2024 · 0 comments

Comments

@jrafanie
Copy link
Member

jrafanie commented Feb 27, 2024

We run code coverage stats on master only. Therefore, instead of updating the code coverage if conditional to reference the new release branch and possibly new ruby version, we should remove the code coverage section entirely.

    - name: Report code coverage
      if: "${{ github.ref == 'refs/heads/master' && matrix.ruby-version == '3.0' &&
        matrix.test-suite == 'vmdb' }}"
      continue-on-error: true
      uses: paambaati/codeclimate-action@v5

See:
ManageIQ/manageiq#22912 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant