Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge dated VimPerformanceStates #11868

Closed
Tracked by #22593
isimluk opened this issue Oct 12, 2016 · 13 comments · Fixed by #22605
Closed
Tracked by #22593

Purge dated VimPerformanceStates #11868

isimluk opened this issue Oct 12, 2016 · 13 comments · Fixed by #22605
Assignees

Comments

@isimluk
Copy link
Member

isimluk commented Oct 12, 2016

As per #11016 (comment) we are not purging datad VimPerformanceStates

/cc @gtanzillo

@miq-bot
Copy link
Member

miq-bot commented Oct 7, 2017

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@Fryguy Fryguy assigned kbrock and unassigned isimluk Oct 9, 2017
@Fryguy
Copy link
Member

Fryguy commented Oct 9, 2017

@kbrock Is this still on your plate and if so, do you want to un-stale it?

@kbrock kbrock removed the stale label Nov 1, 2017
@kbrock
Copy link
Member

kbrock commented Nov 1, 2017

@Fryguy think this one is still not purged. It slipped through the cracks. Sorry I did not state this on Mar 1 (when I reopened)

What logic do we use to determine stale/old/purgeable VimPerformanceState records?

@Fryguy
Copy link
Member

Fryguy commented Nov 27, 2017

Probably you can use the timestamp?

@miq-bot
Copy link
Member

miq-bot commented May 28, 2018

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

@miq-bot miq-bot added the stale label May 28, 2018
@JPrause
Copy link
Member

JPrause commented Jan 23, 2019

@isimluk is this still a valid issue. If not can you close.
If there's no update by next week, I'll be closing this issue.

@JPrause
Copy link
Member

JPrause commented Jan 29, 2019

Closing issue. If you feel the issue needs to remain open, please let me know and it will be reopened.
@miq-bot close_issue

@miq-bot miq-bot closed this as completed Jan 29, 2019
@kbrock
Copy link
Member

kbrock commented Jan 30, 2019

This was fixed in #16754

@jrafanie
Copy link
Member

Resurrecting this issue... purging just orphaned states means we still retain "live" object's states forever.

@jrafanie jrafanie reopened this Jun 29, 2023
@miq-bot
Copy link
Member

miq-bot commented Jun 29, 2023

@isimluk 'isimluk' is an invalid assignee, ignoring...

@isimluk
Copy link
Member Author

isimluk commented Jun 30, 2023

@jrafanie
Copy link
Member

@isimluk sorry about the ping... When I reopened the issue, I guess the bot replied to your initial comment to assign yourself.

I hope you're doing well. 👋

@isimluk
Copy link
Member Author

isimluk commented Jul 1, 2023

Hello @jrafanie, I hope you are doing well too. And no need to apologize. I have fond memories of ManageIQ team and the codebase, and don't mind being reminded of it every morning. So, I am sorry about vandalizing the purging issue with a gif. Take care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants