Enhancement: Ability to disable unused providers

[bekasovoleg]

Gemfile has a group for each provider, but if provider gem isn't installed, miq doesn't work
It would be great to have the ability to disable certain providers

[agrare]

@bekasovoleg This is absolutely the goal, however MIQ core isn't in a place yet where we can not bundle provider plugins. There are still places where class names are hard-coded for example.

This is ongoing and we are constantly trying to improve but we're not there yet.

cc @juliancheal

[Fryguy]

@jrafanie This falls into your bundler groups work. If you want to close in favor of some other issues you have open, please feel free.

[jrafanie]

@bekasovoleg have you tried putting the provider gem(s) into an optional group, like this and then use bundle install --with GROUPNAME to opt-in to installing those gems?

[bekasovoleg]

@jrafanie Miq does'n start if some group isn't installed

[juliancheal]

@jrafanie for reference #16162 (comment)

[jrafanie]

@jrafanie for reference #16162 (comment)

I'm sure it's been fixed in over 2 years... 🤣

[jrafanie]

@jrafanie Miq does'n start if some group isn't installed

@bekasovoleg is it the issue Julian referenced or something else?

[bekasovoleg]

@jrafanie looks like I have the same problem

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.

[jrafanie]

For reference, the reported issue was that the UI needed the openstack provider installed so it can call things "nodes" (openstack) or "hosts" (non-openstack) via #16162 (comment)

That prevented running the application without the openstack gems installed because the UI couldn't load the provider classes.

That code has since been removed in UI classic so I think you should be able to bundle install without specific bundler groups. @agrare what do you think? The issue reported was in regards to starting the app without some dependencies not installed, which is only possible by disabling bundler group via --without. It sounds like this is a bit different than being able to install packages for specific providers. We might want to discuss what that means.

[agrare]

We're still a ways away from being able to disable provider plugins. Some could probably be disabled, but most/all definitely not yet.

For instance we still have code like this, this and this in the UI so without those providers bundled the UI will fail.

The move to provider defined DDF forms (#18818) should help with a lot of this (especially the ones in ems_common/angular) the rest we'll just have to deal with one-by-one

[agrare]

It sounds like this is a bit different than being able to install packages for specific providers. We might want to discuss what that means.

That is true, on a built appliance I think disabling still has the same issue as enabling new plugins which is dealing with the Gemfile.lock though but I agree that should be discussed in a separate issue

[skateman]

I think DDF will do this out-of-the box for free, because it relies on the loaded subclasses in the object space.