Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor user provided execution_ttl option #17476

Merged
merged 1 commit into from
May 29, 2018
Merged

Honor user provided execution_ttl option #17476

merged 1 commit into from
May 29, 2018

Conversation

bzwei
Copy link
Contributor

@bzwei bzwei commented May 24, 2018

PlaybookRunner is a subclass of Job. Previously it depends on Job DEFAULT_TIMEOUT which equals 5 minutes. If the playbook does not complete before this timeout, it gets abort.

PlaybookRunner already takes option execution_ttl in minutes from user when the automate playbook method is defined. This number is now used to override current_job_timeout method. If this option is not given a new default 10 minute is used instead.

fixes https://bugzilla.redhat.com/show_bug.cgi?id=1581465

@bzwei
Copy link
Contributor Author

bzwei commented May 24, 2018

@miq-bot assign @mkanoor
@miq-bot add_label bug, gaprindashvili/yes

@miq-bot
Copy link
Member

miq-bot commented May 24, 2018

Checked commit bzwei@bfb3c7a with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@bzwei
Copy link
Contributor Author

bzwei commented May 25, 2018

@tinaafitz please review

@JPrause
Copy link
Member

JPrause commented May 29, 2018

@miq-bot add_label blocker

tinaafitz
tinaafitz approved these changes May 29, 2018
View reviewed changes
Copy link
Member

@tinaafitz tinaafitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzwei Looks good.

@tinaafitz
Copy link
Member

@mkanoor Please review.

@mkanoor mkanoor merged commit 75cbaf4 into ManageIQ:master May 29, 2018
@mkanoor mkanoor added this to the Sprint 87 Ending Jun 4, 2018 milestone May 29, 2018
simaishi pushed a commit that referenced this pull request May 29, 2018
@mkanoor @simaishi
Merge pull request #17476 from bzwei/playbook_runner_ttl
0da130d 
Honor user provided execution_ttl option
(cherry picked from commit 75cbaf4)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1583851
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 0da130d89ed6644a6feca4ce1d33c8cba0b15f5d
Author: Madhu Kanoor <mkanoor@redhat.com>
Date:   Tue May 29 14:50:21 2018 -0400

    Merge pull request #17476 from bzwei/playbook_runner_ttl
    
    Honor user provided execution_ttl option
    (cherry picked from commit 75cbaf4e1a9b5cf7bd9519c0f69b80dfa90740cb)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1583851

@carbonin carbonin mentioned this pull request Jul 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tinaafitz tinaafitz tinaafitz approved these changes

@mkanoor mkanoor mkanoor approved these changes

Assignees

@mkanoor mkanoor

Labels
blocker bug gaprindashvili/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bzwei @miq-bot @JPrause @tinaafitz @simaishi @mkanoor