Slideout.close() method doesn't remove slideout-open class from html tag #196
Labels
Comments
|
Hi @alexandr-bbm! Yes, you are right. I'm going to work on a new version using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thank the authors for this nice lib.
We noticed some kind of bug case:
User opens a modal popup from slideout menu. Our modal component adds class
modal-opento the<body >tag via jQuery.addClass() method. So, the class attribute of<body>tag changes from ' slideout-opento 'slideout-open modal-open(please notice a dissapeared space before slideout-open). Then, we need to close slideout programmatically which is done by Slideout.Close() method. However, this method removes the class in the following way:html.className = html.className.replace(/ slideout-open/, '');Source: Line 123i.e. it supposes class
slideout-opento have a space before it.Why can't we replace
slideout-openclass without the space before it? This will solve this case and will not break any other.The text was updated successfully, but these errors were encountered: