Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publisher Enhancements - Points Table #1468

Open
terrypacker opened this issue Jul 30, 2019 · 2 comments
Open

Publisher Enhancements - Points Table #1468

terrypacker opened this issue Jul 30, 2019 · 2 comments

Comments

@terrypacker
Copy link
Contributor

We will want to:

  1. break out the published points into their own table
  2. Add a method to publisher RT that allows getting the status for a running publisher, then use this in a general purpose endpoint
  3. Add additional information to the published point model about runtime status (will be a generic method on the PublisherRT/PublishedPointRT) and return this from a new query points endpoint.
@terrypacker terrypacker added this to the 3.7.0 Release milestone Jul 30, 2019
@terrypacker
Copy link
Contributor Author

terrypacker commented Aug 29, 2019

One complexity is that we already have 2 v2 REST controllers for publishers and both use models with a List of points in the publisher.

Proposed solution:

  1. Add a new parameter to all publisher-v2 endpoints that allows to optionally exclude the points from the model. To keep legacy compatibility this will default to including the points. I would also make the points field only included when it is non-null.

  2. Provide a new REST controller for publisher-points where one can access the points independent of being in a publisher model container.

@jazdw
Copy link
Contributor

jazdw commented Aug 29, 2019

I would also make the points field only included when it is non-null.

You mean the property in the JSON model? Yes I agree.

Provide a new REST controller

I think an endpoint in the existing controller would suffice.

@terrypacker terrypacker removed this from the 3.7.0 Release milestone Oct 9, 2019
@terrypacker terrypacker changed the title Publisher Enhancements Mango 3.7 Publisher Enhancements Pre Mango 4.0 Oct 9, 2019
@terrypacker terrypacker changed the title Publisher Enhancements Pre Mango 4.0 Publisher Enhancements - Points Table May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants