-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to obtain raw data for reproduction #1
Comments
Hello, We weren't able to find any clear documentation on how to use QUAL, and FILTER so those were ignored. We are happy to incorporate it if you could provide some instructions on how to use them. |
I used QUAL to generate ROC curves which are more informative than just single points. For callers not reporting a QUAL score I use # supporting reads as a proxy as that's typically what's used in a as cut-off. In your case Figures 1ef, and 3ef would benefit from QUAL lines. Similarly, using FILTER to split out caller results into a FILTER=PASS subset, and an all call subset is valuable. Your Fig 2 is also a bit strange. I would have thought Fig2 should plot only TPs with an x axis of 'length of called variant - true length of variant'. As it is, it appears to be plotting whether the caller makes more small or large del calls, not how accurately the caller reports the length of the variants that it does call. Happy to unofficially review your preprint if you're interested in more comprehensive feedback. Cheers |
Thanks, Daniel for your feedback! We intentionally did plot all SVs not just TPs to see how the distribution of inferred SVs is different from the true ones Varuni, In terms of QUAL we will be happy to incorporate this in the future Serghei |
Hello.
I just saw your preprint go up and was wanting to generate ROC curves from the caller qual scores to compare to your single-point results but it appears the raw data is not available. Would you be able to update your repo and readme with :
bwa mem -a
and am curious what the effect of your choice of aligner settings has on your resultsThe text was updated successfully, but these errors were encountered: