-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments in VMobject should be moved to documentation #1172
Comments
Hi MrMallIronmaker Can I take up this issue, this is my first open source issue, I couldn't completely comprehend the issue, can you please elucidate it a bit more. Thank you |
Hey @mohansaimandalapu, what @MrMallIronmaker is referring to are docstrings which are written between the function's/method's declaration and the implementation. Please refer to our contributing guidelines on providing documentation to the project. There's a section there on adding documentation but this first section to get setup for developing Manim is very necessary to follow. Let me know if you have any further questions! |
Unassigned as it has been 3 months without activity. |
I would like to work on this issue. I am going over contribution guidelines and setting up this project. |
https://ycechung-opensource.blogspot.com/2021/10/yet-another-successful-hacktoberfest.html |
There are comments in the code here:
manim/manim/mobject/types/vectorized_mobject.py
Lines 53 to 76 in 63735d3
of which some should be moved to documentation.
This came up in a discord help request about set_sheen - I had a conversation in Discord (https://discord.com/channels/581738731934056449/669259565941915723/824696707836674098) that was resolved with a proper understanding what sheen_direction does (because it's not clear)
The text was updated successfully, but these errors were encountered: