Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not build with latest rustc #186

Closed
matthiaskrgr opened this issue Sep 25, 2019 · 5 comments
Closed

does not build with latest rustc #186

matthiaskrgr opened this issue Sep 25, 2019 · 5 comments

Comments

@matthiaskrgr
Copy link

Compiletest does not build with the latest rustc probably due to rust-lang/rust#64663

   Compiling compiletest_rs v0.3.22
error[E0063]: missing field `report_time` in initializer of `test::TestOpts`
  --> /home/matthias/.cargo/registry/src/github.com-1ecc6299db9ec823/compiletest_rs-0.3.22/src/lib.rs:98:5
   |
98 |     test::TestOpts {
   |     ^^^^^^^^^^^^^^ missing `report_time`

error: aborting due to previous error

For more information about this error, try `rustc --explain E0063`.
error: could not compile `compiletest_rs`.
@Manishearth
Copy link
Owner

We should probably just pass report_time: false, yeah?

@fenhl
Copy link

fenhl commented Sep 25, 2019

I'm now getting this error when trying to compile this crate on the latest nightly:

error[E0560]: struct `test::TestOpts` has no field named `report_time`
   --> src/lib.rs:129:9
    |
129 |         report_time: false,
    |         ^^^^^^^^^^^ `test::TestOpts` does not have this field
    |
    = note: available fields are: `list`, `filter`, `filter_exact`, `exclude_should_panic`, `run_ignored` ... and 9 others

@Manishearth
Copy link
Owner

This will be automatically fixed in the next nightly, use the previous version of this crate till then.

We fixed the crate for rustc master since we needed that to handle a tangled web of tooling brokenness with Clippy and cargo.

@fenhl
Copy link

fenhl commented Sep 26, 2019

While compiling this crate on its own seems to be fixed on the new nightly, I'm still seeing this issue when trying to run Rocket's scripts/test.sh.

$ rustc --version
rustc 1.40.0-nightly (37538aa13 2019-09-25)

@jebrosen
Copy link

This field is not conditioned on norustc, which I believe causes the error - Rocket uses the stable feature of compiletest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants