Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not compile on rustc 1.19.0-nightly (f4209651e 2017-05-05) #64

Closed
dtolnay opened this issue May 8, 2017 · 10 comments
Closed

Does not compile on rustc 1.19.0-nightly (f4209651e 2017-05-05) #64

dtolnay opened this issue May 8, 2017 · 10 comments

Comments

@dtolnay
Copy link
Contributor

dtolnay commented May 8, 2017

error[E0433]: failed to resolve. Could not find `Options` in `test`
   --> src/lib.rs:146:18
    |
146 |         options: test::Options::new(),
    |                  ^^^^^^^^^^^^^^^^^^ Could not find `Options` in `test`

error[E0560]: struct `test::TestOpts` has no field named `options`
   --> src/lib.rs:146:9
    |
146 |         options: test::Options::new(),
    |         ^^^^^^^^ `test::TestOpts` does not have this field

error: aborting due to previous error
@dtolnay
Copy link
Contributor Author

dtolnay commented May 8, 2017

Looks like this is caused by #63. I believe that commit should be reverted until rustup begins serving a nightly version that includes the break. This dashboard shows that the 2017-05-07 nightly is not out. @SimonSapin

@SimonSapin
Copy link
Contributor

I have an obvious conflict of interest on what should be done with this crate/repo :)

But in the meantime you can downgrade with cargo update -p compiletest_rs --precise 0.2.5

@dtolnay
Copy link
Contributor Author

dtolnay commented May 8, 2017

I can downgrade but putting that command in the .travis.yml of every project that uses compiletest in CI, and then removing it when a new nightly is out, is not reasonable. I believe the change should be reverted until the new nightly is available and being served by rustup.

@SimonSapin
Copy link
Contributor

Fair. I hadn’t thought of CI. It’s up to @laumann or @Manishearth to yank 0.2.6.

@laumann
Copy link
Collaborator

laumann commented May 8, 2017

I can yank 0.2.6 and wait until nightly 2017-05-07 is out - I guess I can just undo the yank later?

@SimonSapin
Copy link
Contributor

Yes, cargo yank --undo is a thing.

@dtolnay
Copy link
Contributor Author

dtolnay commented May 8, 2017

Thanks!

@dtolnay dtolnay closed this as completed May 8, 2017
@oli-obk
Copy link
Contributor

oli-obk commented May 9, 2017

The nightly is out. Please unyank 0.2.6

@oli-obk
Copy link
Contributor

oli-obk commented May 9, 2017

Side note: maybe it would help to enable travis on this repository? There's a .travis.yml, but travis doesn't run.

@laumann
Copy link
Collaborator

laumann commented May 9, 2017

@oli-obk: It's unyanked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants