Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync versions should also implement Default #36

Closed
Porges opened this issue Jan 17, 2023 · 1 comment · Fixed by #37
Closed

sync versions should also implement Default #36

Porges opened this issue Jan 17, 2023 · 1 comment · Fixed by #37

Comments

@Porges
Copy link
Contributor

Porges commented Jan 17, 2023 •
edited
Loading

The non-sync versions implement Default; the sync versions should as well.
@Porges Porges changed the title sync versions should also implement Default sync versions should also implement Default Jan 17, 2023
@Manishearth
Copy link
Owner

I'd accept a PR doing this

@Porges Porges mentioned this issue Jan 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Default implementations for sync versions Porges/elsa
2 participants
@Porges @Manishearth