Skip to content

Commit f1db259

Browse files
committed
Rollup merge of rust-lang#24706 - tamird:remove-DST-comment, r=alexcrichton
`ToCStr` was removed with `old_io` and the current method `as_os_str` is inherent to `Path`, meaning there is no suitable trait bound that could be used here. r? @alexcrichton
2 parents fb0f344 + 4047a7c commit f1db259

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

Diff for: src/libstd/dynamic_lib.rs

-8
Original file line numberDiff line numberDiff line change
@@ -40,14 +40,6 @@ impl Drop for DynamicLibrary {
4040
}
4141

4242
impl DynamicLibrary {
43-
// FIXME (#12938): Until DST lands, we cannot decompose &str into
44-
// & and str, so we cannot usefully take ToCStr arguments by
45-
// reference (without forcing an additional & around &str). So we
46-
// are instead temporarily adding an instance for &Path, so that
47-
// we can take ToCStr as owned. When DST lands, the &Path instance
48-
// should be removed, and arguments bound by ToCStr should be
49-
// passed by reference. (Here: in the `open` method.)
50-
5143
/// Lazily open a dynamic library. When passed None it gives a
5244
/// handle to the calling process
5345
pub fn open(filename: Option<&Path>) -> Result<DynamicLibrary, String> {

0 commit comments

Comments
 (0)