Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discussion]Remove custom rpc methods except mantapay/mantasbt's #1230

Open
Dengjianping opened this issue Jul 21, 2023 · 0 comments
Open

[Discussion]Remove custom rpc methods except mantapay/mantasbt's #1230

Dengjianping opened this issue Jul 21, 2023 · 0 comments
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-client Client - i.e. not upgradeable with the runtime - changes A-manta Area: Issues and PRs related to the Manta Runtime C-discussion Category: Discussion or questions that don't represent real issues L-deprecated Log: Issues and PRs related to deprication

Comments

@Dengjianping
Copy link
Contributor

Currently all rpc methods can be queried from runtime APIs by state_call. Just like

api.rpc.state.call('method_name', bytes);

Pros:

  • No need to maintain custom rpc crates.
  • Node redeployment will become unnecessary(it depends).
  • Shorten compile time(maybe a little bit), and shrink the size of client(maybe a little bit as well).

Cons:

  • Performance. But if no extra decoding/encoding in rpc methods, performance should be affected.
  • Frontend. Frontend team has to rewrite the part of calling custom rpc methods.
@Dengjianping Dengjianping added A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime C-discussion Category: Discussion or questions that don't represent real issues L-deprecated Log: Issues and PRs related to deprication A-client Client - i.e. not upgradeable with the runtime - changes labels Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-client Client - i.e. not upgradeable with the runtime - changes A-manta Area: Issues and PRs related to the Manta Runtime C-discussion Category: Discussion or questions that don't represent real issues L-deprecated Log: Issues and PRs related to deprication
Projects
None yet
Development

No branches or pull requests

1 participant