Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide easy mechanism for collator runners to benchmark their machines #390

Closed
ghzlatarev opened this issue Feb 9, 2022 · 1 comment · Fixed by #571
Closed

Provide easy mechanism for collator runners to benchmark their machines #390

ghzlatarev opened this issue Feb 9, 2022 · 1 comment · Fixed by #571
Assignees
Labels
A-collator-program Area: Issues and PRs related to the Collator Program P-low Priority: Low
Milestone

Comments

@ghzlatarev
Copy link
Contributor

The easy solution is https://dev.kilt.io/docs/chain/collator/#benchmarking We can outline how a collator runner can benchmark their machine. Basically let them build a binary with the runtime-benchmarks flag and optimizations, run the benchmark and compare to our official weights. If their weights are lower or insignificantly higher, then the machine should be fine
or we can provide a benchmarking binary as one of the release artifacts

The other solution is to implement a subcommand similar to polkadot's https://github.com/paritytech/polkadot/blob/master/cli/src/command.rs#L442
This checks pvf generation time, which is not exactly the what we want for collators. but we could implement something similar. The baseline benchmark looks okay.

@ghzlatarev ghzlatarev added P-low Priority: Low A-collator-program Area: Issues and PRs related to the Collator Program labels Feb 9, 2022
@ghzlatarev ghzlatarev self-assigned this Feb 9, 2022
@Garandor
Copy link
Contributor

Garandor commented May 3, 2022

This should be addressed by upstream paritytech/substrate#11198

We just need to create docs for it

@ghzlatarev ghzlatarev mentioned this issue Jun 6, 2022
10 tasks
@ghzlatarev ghzlatarev added this to the v3.2.1 milestone Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-collator-program Area: Issues and PRs related to the Collator Program P-low Priority: Low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants