-
Notifications
You must be signed in to change notification settings - Fork 12
Clarify if "input@position values" are tile or extent #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'll think a bit more about this, but you are probably aware that xmin etc are variable names that are have no meaning on the client other than relating the URL template position in I think @pomakis should be involved as they've implemented MapML on their server too. And this discussion isn't so much about the link template as it is about the attributes and their values for the Currently, we are using the |
Note that there is
I'm not sure if such a rel would ever be necessary, since it could be deduced from the fact that |
I guess you could be in search of the tiles that are the rough locations of the corners of the extent, so you might want to use it like this:
Unsure if that would ever be useful. |
And yes, I debated whether 'image' should have been 'extent' but since 'image' already existed as a rel value, I decided against adding a new value for the same concept. YMMV. |
That is correct.
I see what you mean but I object on having attributes with fuzzy meaning. My interpretation is that we need 3 things:
That might be a way out. "corner" remains only the "extreme" name and "rel" could tell us about the "object" name: Tile or image. I like that. In the end 4 things will tell us exactly what we are talking about. |
So do you agree with the current design? I take it by "corner" you are talking about the current
|
I agree if the following changes are accepted: The following case should be considered wrong:
and should be:
|
That looks wrong too because you are requesting the row axis (which does not apply to pcrs) so you would get ?nothing? or if leniency was applied perhaps the vertical axis? |
My appologies. You are completelly right and I was distracted. it should be:
|
So we agree on the above, with the caveat that rel=image is redundant because it is the default rel. OK? On the other hand, to go back one:
I would not say that the input is wrong, but the URL template won't be filled in correctly because you'll be serializing a row value for the upper left hand corner of the extent, which won't return anything useful from a WMS. But I won't say the input is strictly wrong. Perhaps that is what you meant by wrong?? If you are confused, I am discouraged for the school children I hope to convert to MapML, and we should try harder to make it not confusing, I agree. |
Yes
Yes. That is exactly what should happen. |
Great this is actually implemented now, closing. |
The issue emerged from this two possible syntax:
A:
<link rel="tile" tref="http://maps.nofc.cfs.nrcan.gc.ca/geoserver/public/wms?service=WMS&version=1.1.0&request=GetMap&layers=public:fdr_current&styles=&bbox={xmin},{ymin},{xmax},{ymax}&width=256&height=256&srs=EPSG:3978&FORMAT=image/png&TRANSPARENT=TRUE&m4h=t"/>
B:
<link rel="image" tref="http://maps.nofc.cfs.nrcan.gc.ca/geoserver/public/wms?service=WMS&version=1.1.0&request=GetMap&layers=public:fdr_current&styles=&bbox={xmin},{ymin},{xmax},{ymax}&width=256&height=256&srs=EPSG:3978&FORMAT=image/png&TRANSPARENT=TRUE&m4h=t"/>
In both cases {xmin},{ymin},{xmax},{ymax} are numbers in the projected CRS (assumed as units=pcrs) but in the first case they need to have "tile" positions and in the second "extent" positions.
Please expand the table to include:
Keyword State
tile-top-left Identifies a location relative to a tile.
tile-top-right Identifies a location relative to a tile.
tile-bottom-left Identifies a location relative to a tile.
tile-bottom-right Identifies a location relative to a tile.
tile-center-left Identifies a location relative to a tile.
tile-center-right Identifies a location relative to a tile.
tile-top-center Identifies a location relative to a tile.
tile-bottom-center Identifies a location relative to a tile.
tile-center Identifies a location relative to a tile.
extent-top-left Identifies a location relative to the extent.
extent-top-right Identifies a location relative to the extent.
extent-bottom-left Identifies a location relative to the extent.
extent-bottom-right Identifies a location relative to the extent.
extent-center-left Identifies a location relative to the extent.
extent-center-right Identifies a location relative to the extent.
extent-top-center Identifies a location relative to the extent.
extent-bottom-center Identifies a location relative to the extent.
extent-center Identifies a location relative to the extent.
The text was updated successfully, but these errors were encountered: