-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resources should be minified #153
Comments
A minified version of mapml is provided in the build branch and in releases, but having a minified version of the other javascript files would be good too. |
@ahmadayubi Is Would it be acceptable to simply uglify/minify everything in the |
It's currently not used anywhere as the tests and experiments files people usually debug on so it's important they can read it (without having to pretty print in chrome debugger), you could definitely minify everything but it would add an extra step to debugging. It wouldn't be a big deal though, it's mostly a preference thing I believe. @prushforth has developed the minification process through GruntJS, maybe he could shed light on his decision to offer both .min.js and .js I'm not sure what the mapml.min.js file is for currently, it could be used in the mapml-viewer.min.js file if that's ever added in the future. |
Unless we generate source maps using grunt-contrib-uglify's sourceMap option? |
That would definitely work (after setting up and testing to make sure it works as expected), I hadn't considered using source maps in the past. |
Addressed by #705 |
Google's Lighthouse reports a potential saving of 148.6 kb in transfer size (not including CSS):
We should:
Of course, license text should be preserved.
The text was updated successfully, but these errors were encountered: