Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources should be minified #153

Closed
2 tasks done
Malvoz opened this issue Aug 24, 2020 · 6 comments
Closed
2 tasks done

Resources should be minified #153

Malvoz opened this issue Aug 24, 2020 · 6 comments
Assignees
Milestone

Comments

@Malvoz
Copy link
Member

Malvoz commented Aug 24, 2020

Google's Lighthouse reports a potential saving of 148.6 kb in transfer size (not including CSS):

We should:

Of course, license text should be preserved.

@ahmadayubi
Copy link
Member

A minified version of mapml is provided in the build branch and in releases, but having a minified version of the other javascript files would be good too.

@Malvoz
Copy link
Member Author

Malvoz commented Nov 9, 2021

A minified version of mapml is provided in the build branch and in releases

@ahmadayubi Is mapml.min.js used anywhere?

Would it be acceptable to simply uglify/minify everything in the dist folder without outputting .min.(js|css) file names?

@ahmadayubi
Copy link
Member

ahmadayubi commented Nov 10, 2021

It's currently not used anywhere as the tests and experiments files people usually debug on so it's important they can read it (without having to pretty print in chrome debugger), you could definitely minify everything but it would add an extra step to debugging.

It wouldn't be a big deal though, it's mostly a preference thing I believe. @prushforth has developed the minification process through GruntJS, maybe he could shed light on his decision to offer both .min.js and .js

I'm not sure what the mapml.min.js file is for currently, it could be used in the mapml-viewer.min.js file if that's ever added in the future.

@Malvoz Malvoz removed this from the v0.9.0 milestone Jan 4, 2022
@Malvoz
Copy link
Member Author

Malvoz commented Jan 10, 2022

you could definitely minify everything but it would add an extra step to debugging.

Unless we generate source maps using grunt-contrib-uglify's sourceMap option?

@ahmadayubi
Copy link
Member

That would definitely work (after setting up and testing to make sure it works as expected), I hadn't considered using source maps in the past.

@prushforth prushforth added this to the Winter 2023 milestone Dec 9, 2022
@AliyanH AliyanH mentioned this issue Dec 12, 2022
4 tasks
@prushforth
Copy link
Member

Addressed by #705

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants