-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popups should be programmatically determinable #354
Comments
Accessibility expert Scott O'Hara stated in w3c/aria#1421 (comment):
(the example provided was https://maps4html.org/experiments/index.html) With that response I do think we should use |
Apologies for missing this earlier. I agree that I'm also noticing this very interesting bug on NVDA + Chrome/Firefox where opening a popup with the keyboard causes the popup to open very left and very up of the actual point, so much so that the map scrolls. I'm not sure how much of this is MapML and how much of it is Leaflet since last I checked, Leafalet didn't even have popups that were keyboard accessible, but possibly worth noting. |
Thanks Nic.
I agree, and it'd indeed be great if Leaflet provided that as an option. I'll file an issue on that with them.
The bug you're seeing with misplaced popups has been noted in comments before, but it deserves its own issue: filed #423. And it's true Leaflet markers aren't operable using screen readers, setting |
The
leaflet-popup
is a plain<div>
(click any marker to view a popup here: https://maps4html.org/experiments/index.html). I believe it is a failure of SC 1.3.1 Info and Relationships to not convey its structure (as visually presented) to ATs. This issue is on the list of upstream accessibility issues (for popups).I'd like to think that
role="dialog"
is appropriate for the element, but I'm not sure (we can hopefully get some feedback on this per w3c/aria#1421 (comment)). WDYT? Isdialog
appropriate for popups?/cc @shepazu and @nchan0154, in case you have any opinions on this. 🤗
The text was updated successfully, but these errors were encountered: