Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo has issues #79

Closed
Malvoz opened this issue Aug 8, 2018 · 5 comments
Closed

Demo has issues #79

Malvoz opened this issue Aug 8, 2018 · 5 comments

Comments

@Malvoz
Copy link
Member

Malvoz commented Aug 8, 2018

In the demo at https://maps4html.github.io/Web-Map-Custom-Element/ alot of resources from https://geoappext.nrcan.gc.ca returns 404. It seems Cross-Origin Resource Blocking (CORB) is in effect.

@prushforth
Copy link
Member

Yes, I noticed that. There are a couple of issues. First the client currently doesn't well respect the bounds that are set up by the <input type=location min=... max=...> elements in the <extent>. That will help alleviate some 404s when I'm able to fix that. Next, the service for the CBMT has recently (I think) started returning text/html instead of a blank image/*. That is why the CORB message is happening, I believe. I did report this to the service owner and asked to get a blank image returned instead of the text/html. But vacations being the thing right now I'm not sure when it will get addressed.

The demo is also on a very old version of the client. Hopefully will get some time in the fall to bring everything up to date.

I will close this issue when I get the CORB problem addressed. Thanks for commenting.

@Malvoz
Copy link
Member Author

Malvoz commented Aug 8, 2018

Thanks @prushforth, my intention of using the demo today was to inspect image requests when navigating the map. There's alot happening in the world of images (and embeds) on the web concerning performance and user bandwidth, e.g: image decoding, lazyload, priority hints and also CSS containment.

Is this something you'd care to look at? Obviously this too applies to Leaflet, I may instead open an issue over there. However if (when?) Maps4HTML stop relying on Leaflet these are still things to consider.

@prushforth
Copy link
Member

Leaflet is great, and its code has been how I learned what is good quality code, not that I reproduce that quality usually. As time goes by, I hope to move to first no dependencies and then to native code.

But if such considerations apply to the <img> element, then they probably will apply to the MapML <tile> and <image> elements as well, so bring it on as necessary; please post a link back here from your Leaflet issues, and I will follow those individually.

@Malvoz
Copy link
Member Author

Malvoz commented Aug 9, 2018

There you go! :) Leaflet/issues/6283

@Malvoz
Copy link
Member Author

Malvoz commented Jan 27, 2020

No CORB issues anymore AFAICT, closing.

@Malvoz Malvoz closed this as completed Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants