-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename <mm-app> to <mapml-viewer> #104
Comments
@prushforth what's your opinion on this? I suspect I haven't been clear enough on the severity of the accessibility issue of the built-in I suggest we update the README.md to include instructions and example code using |
OK sorry it's taken so long to address. I am willing but believe that the porting to |
@Malvoz certain influential parties have recently dumped on the whole MapML project. In consequence, I would prefer to name the custom element mapml-viewer, because I have put my guts into this one. Would you be ok with that? |
In worst case scenario, we still have a beautiful map component that is easy to use for developers.
Interesting, it doesn't come as a total surprise, I'd like to learn more about their reasonings. Don't think we should be discouraged.
Yes. |
Thanks for your support, it means a lot. Their reasoning is here |
|
We should focus our demo / index page usage on |
<mm-mapp>
is hard to remember, and it isn't self-descriptive. I see from the commit messages in #91 that the intention was initially<mm-app>
, which was later supposed to be changed to<mm-map>
, but was actually changed to<mm-mapp>
(notably https://geogratis.gc.ca/mapml/ still uses<mm-app>
).Can we settle on something more descriptive, that is easier to remember, and maybe more attractive to developers?
Perhaps
<map-embed>
or<map-viewer>
?A
<map->
autonomous custom element may also an option(?), but perhaps it's best to have something more distinguishable from<map>
.The text was updated successfully, but these errors were encountered: