Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please consider making Base public #8

Open
sgmihai opened this issue May 2, 2023 · 0 comments
Open

Please consider making Base public #8

sgmihai opened this issue May 2, 2023 · 0 comments

Comments

@sgmihai
Copy link

sgmihai commented May 2, 2023

Base: seq[T]

Base is not public so it's not very convenient to directly map a chunk of data, like a string, that is already the bitfield we want:

  bitField = newBitVector[uint](strBitField.len*8)
  copyMem(bitField.Base[0].addr, strBitField[0].unsafeAddr, strBitField.len)

That, or make helper procs to init bitfield from most common sequential data structures. But still I see no harm in making Base public so people can do whatever they want to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant