Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs more tests #12

Open
MarcL opened this issue Aug 21, 2017 · 3 comments
Open

Needs more tests #12

MarcL opened this issue Aug 21, 2017 · 3 comments

Comments

@MarcL
Copy link
Owner

MarcL commented Aug 21, 2017

Need to add some more tests for AmazonAPI

  • Test data transformations work as expected
  • Test double for HttpRequest
  • Check expected Amazon signature for signed requests
@MarcL
Copy link
Owner Author

MarcL commented Nov 13, 2017

Added some in #17 and #18.

@prakashchhetri
Copy link

$this->amazonAPI = new AmazonAPI($urlBuilder, 'simple');
[

{
asin: "B01KA7VWWC",
url: "https://www.amazon.com/Coffee-Brewer-System-Carafe-CF091/dp/B01KA7VWWC?SubscriptionId=XXXXXX&tag=XXXXX-XXXX&linkCode=xm2&camp=2025&creative=165953&creativeASIN=B01KA7VWWC",
rrp: 199.99,
title: "Ninja Coffee Bar Brewer System with Glass Carafe (CF091)",
lowestPrice: 151.76,
largeImage: "",
mediumImage: "",
smallImage: ""
}
]

The images arent returned. But if we check the json version of it, we can see the images being returned.

@MarcL
Copy link
Owner Author

MarcL commented Jan 3, 2018

Can you raise a new issue please @prakashchhetri? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants