Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File locking problems since v1.96 #112

Open
sammoth opened this issue Feb 1, 2023 · 2 comments
Open

File locking problems since v1.96 #112

sammoth opened this issue Feb 1, 2023 · 2 comments

Comments

@sammoth
Copy link

sammoth commented Feb 1, 2023

Hi, I saw there is a comment on the wiki about not being able to rename or delete files on external drives while QL is thumbnailing and that this is unavoidable. I didn't encounter this issue before 1.96, but since installing the 'Finder extension' version of QLVideo every file that is thumbnailed will be locked in this manner for maybe 30 seconds-2 minutes, and this happens on my root drive.

This is easily reproducible for me using version 2.00:

  • Open a folder in finder, eg. Desktop
  • Generate a blank video in that folder using ffmpeg like ffmpeg -t 60 -s 640x480 -f rawvideo -pix_fmt rgb24 -r 30 -i /dev/zero empty.mkv
  • After ffmpeg finishes, the video file does not have a thumbnail, for at least multiple minutes, but resetting quicklook and restarting Finder will immediately generate the thumbnail
  • Trying to delete the file immediately after ffmpeg finishes will hang for 1+ minute

Rolling back to 1.95 fixes this problem completely, on Ventura 13.1. With 1.95:

  • The thumbnail appears immediately after ffmpeg finishes
  • The file can be immediately deleted

I realise this might be an Apple issue with the handling different type of extension but I thought I would report it anyway. Thank you for QLVideo!

@goodman-capu
Copy link

goodman-capu commented Apr 8, 2023

Thanks for the solution. Rolling back to pre-1.96 fixed all the problems for me in Ventura 13.3

How did you conclude it's an Apple problem? IMO it's qlvideo taking too long & too much CPU to generate thumbnail that caused the hang.

BTW this is the command to install v1.94 (no 1.95 available in brew)

brew install --cask https://raw.githubusercontent.com/Homebrew/homebrew-cask/3670a86a4cac36cf7a8a7d5dc9ec1e84068df4dd/Casks/qlvideo.rb

@Kagami
Copy link

Kagami commented Oct 1, 2023

killall -9 com.apple.quicklook.ThumbnailsAgent helps to unstuck thumbnailer on my machine (but be cautious with that command, not sure if it's safe).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants