Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black borders in thumbnails #118

Closed
Kagami opened this issue Oct 3, 2023 · 1 comment
Closed

Black borders in thumbnails #118

Kagami opened this issue Oct 3, 2023 · 1 comment

Comments

@Kagami
Copy link

Kagami commented Oct 3, 2023

Hi,

Thanks for great plugin, I like it a lot. Mostly works without issues.
But one visual unfortunate glitch is that it generates black borders for small video thumbnails in icon view in Finder. This doesn't happen with photo thumbnails. See attached screenshots.

I found this issue #19 which was resolved.
But then it was discussed again here #63 (comment) and it seems to be a flaw of Quick Look Plugin API? So no workaround possible? Please confirm if so.

Although cover thumbnails for mkv look fine. See last screenshot. Is it possible to generate thumbnails from video frames in the same way?

Thanks.



@Kagami Kagami changed the title Black borders to video files Black borders in thumbnails Oct 3, 2023
@Marginal
Copy link
Owner

Marginal commented Oct 5, 2023

Finder decorates thumbnails according to file type - thin white borders for pictures (like a printed photo), black borders for movies (like letterbox mattes), no borders for movie cover art (like a physical film poster?). There are also some other obscure/historical decorations.

I could suppress the black borders or replace them with something else, but I wanted to stay consistent with macOS behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants