Keeping the other check just to be safe

Maria Solano · Maria Solano · commit 2f36455ca94c · 2023-03-27T12:17:40.000-07:00
diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
@@ -35687,7 +35687,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {
                     error(errorNode, Diagnostics.A_function_whose_declared_type_is_neither_void_nor_any_must_return_a_value);
                 }
             }
-            else if (type && strictNullChecks) {
+            else if (type && strictNullChecks && !isTypeAssignableTo(undefinedType, type)) {
                 error(errorNode, Diagnostics.Function_lacks_ending_return_statement_and_return_type_does_not_include_undefined);
             }
             else if (compilerOptions.noImplicitReturns) {

Original file line number	Diff line number	Diff line change
`@@ -35687,7 +35687,7 @@ export function createTypeChecker(host: TypeCheckerHost): TypeChecker {`
`35687`	`35687`	`error(errorNode, Diagnostics.A_function_whose_declared_type_is_neither_void_nor_any_must_return_a_value);`
`35688`	`35688`	`}`
`35689`	`35689`	`}`
`35690`		`- else if (type && strictNullChecks) {`
	`35690`	`+ else if (type && strictNullChecks && !isTypeAssignableTo(undefinedType, type)) {`
`35691`	`35691`	`error(errorNode, Diagnostics.Function_lacks_ending_return_statement_and_return_type_does_not_include_undefined);`
`35692`	`35692`	`}`
`35693`	`35693`	`else if (compilerOptions.noImplicitReturns) {`