Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on netlify config when migrating Node.js #2246

Closed
1 task
yucheng11122017 opened this issue Mar 28, 2023 · 2 comments · Fixed by #2554
Closed
1 task

Add note on netlify config when migrating Node.js #2246

yucheng11122017 opened this issue Mar 28, 2023 · 2 comments · Fixed by #2554

Comments

@yucheng11122017
Copy link
Contributor

yucheng11122017 commented Mar 28, 2023

Please confirm that you have searched existing issues in the repo

Yes, I have searched the existing issues

Any related issues?

No response

What is the area that this feature belongs to?

No response

Is your feature request related to a problem? Please describe.

It would be helpful to new developers to have instructions on how to migrate in the DG similiar to 'Migrating to Typescript'.

Describe the solution you'd like

Include checklist and steps needed for migrating in DG.

This can take reference from what was done in #2233 when migrating to node v16 from v14

Left with one TODO:

  • After Specify Netlify build settings #2277, the netlify setting for deploying our documentation on markbind-master is configured using the netlify.toml in our root folder. When migrating, we should change the Node.js version specified in that file accordingly. Hence, we should mention this step in the migrating to Node.js docs

Describe alternatives you've considered

No response

Additional context

No response

@tlylt tlylt changed the title Add documentation on migrating Add documentation on migrating Node.js Mar 28, 2023
@jovyntls
Copy link
Contributor

Hi @yucheng11122017, just checking, is this closed by #2256? Is there anything else that we should add to our DG related to Node.js migration?

@tlylt
Copy link
Contributor

tlylt commented Apr 15, 2023

@jovyntls I think so, but I realized I accidentally introduced a place that needs updating the docs for (#2277). Will modify and make use of this issue for that.

@tlylt tlylt changed the title Add documentation on migrating Node.js Add note on netlify config when migrating Node.js Apr 15, 2023
@jingting1412 jingting1412 self-assigned this Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants