Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support disqus #481

Closed
damithc opened this issue Dec 21, 2018 · 8 comments · Fixed by #1449
Closed

Support disqus #481

damithc opened this issue Dec 21, 2018 · 8 comments · Fixed by #1449

Comments

@damithc
Copy link
Contributor

damithc commented Dec 21, 2018

We can support an easy way for authors to enable user comments using the Disqus tool

@VincentTam
Copy link

Disqus has a plethora of shortcomings that deter many bloggers, say

  1. privacy issues
  2. slow load speed
  3. no markdown support
  4. poor SEO
  5. high cost of migration

You may refer to these articles to know more.

  1. https://victorzhou.com/blog/replacing-disqus/
  2. https://old.reddit.com/r/programming/comments/b9022a/switching_off_of_disqus_reduced_my_page_weight_by/
  3. https://medium.com/remys-blog/ejecting-disqus-4120e9985823

A discussion about Disqus's replacement is available in Pelican-Elegant/elegant#288.

@damithc
Copy link
Contributor Author

damithc commented Jun 26, 2019

Thanks for the heads up @VincentTam
We'll take that into account when we implement this feature.

@damithc
Copy link
Contributor Author

damithc commented Feb 3, 2020

Up ...

@ang-zeyu
Copy link
Contributor

Disqus has a plethora of shortcomings that deter many bloggers, say

  1. privacy issues
  2. slow load speed
  3. no markdown support
  4. poor SEO
  5. high cost of migration

You may refer to these articles to know more.

  1. https://victorzhou.com/blog/replacing-disqus/
  2. https://old.reddit.com/r/programming/comments/b9022a/switching_off_of_disqus_reduced_my_page_weight_by/
  3. https://medium.com/remys-blog/ejecting-disqus-4120e9985823

A discussion about Disqus's replacement is available in Pelican-Elegant/elegant#288.

The speed is still an issue, but we could counter it by adopting lazy loading for the disqus component

I don't think markdown support is of concern to most users =P
On the flip side note that disqus has its own mini editor to include images / bold text / etc.

One could argue only the content of the site should be indexed and not the comments since it may have irrelevant content, hence indexing the comments actually hurts SEO; but either way the impact is really minor here.

Privacy is a thing, though I don't think it matters too much in the context of documentation / education sites.

Overall I think we should still go with disqus first since it has the best integration and one of the few with an ad-based free plan, and is by far the most popular choice still even with its issues.
What do you think? @damithc @VincentTam

@damithc
Copy link
Contributor Author

damithc commented May 23, 2020

@ang-zeyu I agree. I'm OK to go ahead with Disqus first while we keep a lookout for better alternatives.

@ang-zeyu
Copy link
Contributor

Noted, I'm thinking of making it a plugin first, with the configuration supplied under pluginsContext, so it is entirely opt-in.
The author would then be able to use it via a nunjucks variable {{ disqus }}, so one could easily insert it wherever desired (even in the expressive layouts file).

I'm not too sure about the page identifier though, which is used to tie a thread to the page.
If we use the url (omitting the baseurl so that changes to it won't affect the identifier), the issue would be that once versioning is implemented, past threads' comments will not be correctly archived to the past pages as well and will stay in the current version.
I don't think there is any way around this automatically; disqus's migration tools help in migrating to new urls and domains / merging threads but requires manual configuration.

This can actually be desired though (keeping top, useful comments across all versions), what do you think?

@damithc
Copy link
Contributor Author

damithc commented May 23, 2020

This can actually be desired though (keeping top, useful comments across all versions), what do you think?

Yes, I don't mind that behavior.

@ang-zeyu
Copy link
Contributor

or a component <disqus> may be better for extensibility; should be easier to implement as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants