-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support a way to set the primary color of a site #903
Comments
the above link is dead... it's now available at this link instead. |
This won't be accomplished anytime soon, but to list the key issues in the various linked discussions above:
wdyt @jonahtanjz @ryoarmanda @damithc? ps: starting the discussion now as it affects #1702 |
Just to clarify, do you mean removing bootstrap support in general (and have our own styling for our components) or only removing the support for themes but still maintain the use of bootstrap for our components? |
In general, to remove the "bootstrap look", which includes removing bootstrap themes completely. We can certainly still use bootstrap for our components (e.g. The biggest downside is not being able to leverage the professionally designed bootswatch themes, which however currently have many edge cases that aren't functioning correctly and is rather cumbersome to maintain (20+ bootswatch themes). The general idea hence would be to create a more limited, controlled theming system (like mdBook's / mkdocs'). |
I'm not a big fan of full-blown themes myself. They often messes up the content in unintended ways. I use them rarely, if at all. Yes, a more controlled theming feature such as MkDoc's primary color selection feature could be more useful in practice. |
In that case I think this is fine since users can still use Bootstrap features if they want and we can still rely on the Bootstrap components. Removing the use of those classes will definitely take some time and effort to convert 👀
Agree, I think this is a good idea as well and a good place to start :) |
Inspired by https://yakworks.github.io/mkdocs-material-components/getting-started/#primary-colors
The text was updated successfully, but these errors were encountered: