-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
non-configurable timeout for scp #397
Comments
I have similar issue, have you found the workaround? |
Hi, I've created a simple MR for this issue: #423 |
@pekkaklarck can we merge MR which resolves this issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
scp.py has a default but configurable timeout of 10 seconds: https://github.com/jbardin/scp.py/blob/master/scp.py#L103
In our case this is sometimes too short. Our ssh server takes a long time to reply to the connection request (probably because of misconfigured DNS causing DNS lookup timeouts). As a result we get a timeout error.
This timeout does not seem to be configurable without modifying sshlibrary. The connection timeout (used for Read Until) is not forwarded to scp.py, and there is no other way to set it (I don't know if it makes sense to use the same timeout). Only the transport is passed to the SCPClient constructor: https://github.com/robotframework/SSHLibrary/blob/master/src/SSHLibrary/pythonclient.py#L394
Does it make sense to reuse the timeout from the connection configuration for this? If that's appropriate, I think the fix would be reasonably easy to do.
The text was updated successfully, but these errors were encountered: