Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the "tips" and ANSI colors on errors #3557

Closed
simonmeggle opened this issue Apr 19, 2024 · 5 comments
Closed

Remove the "tips" and ANSI colors on errors #3557

simonmeggle opened this issue Apr 19, 2024 · 5 comments
Assignees
Labels
enhancement New feature or request priority: medium
Milestone

Comments

@simonmeggle
Copy link
Contributor

I want to discuss the sense of these “tips” wich always come up on a selector error:

Tip: Use Set Browser Timeout for increasing the timeout or double check your locator as the targeted element(s) couldnt be found.

I think everybody which works with Browser lib for some time has seen this message multiple times - but always takes an decision based on his own judgement and not on what the library proposes.
If, for example, a timeout is exceeded when loading a page, the error message Timeout 10000ms exceeded reads accordingly. This is enough to know what happened.

Increasing the timeout can be a solution to the problem.
Also a wrong locator can be a solution, yes.
But other problems (not mentioned in the tip) are at least as likely.


I already posted in Slack some time ago. But right now I got a request from a customer to "increase the timeout" in a failed test.
Looking closer I saw that the page had a problem and the selector was not found.
This is exactly what I mean: these "Tips" lead to false assumptions, especially on untrained staff.

@aaltat
Copy link
Member

aaltat commented May 2, 2024

@Snooz82 what you think about the proposal?

@Snooz82
Copy link
Member

Snooz82 commented May 2, 2024

@aaltat i am fine with the proposal to streamline the error. and remove the tips!

@aaltat aaltat added enhancement New feature or request priority: medium labels May 2, 2024
@aaltat
Copy link
Member

aaltat commented May 2, 2024

@allcontributors please add @simonmeggle for ideas

Copy link
Contributor

@aaltat

@simonmeggle already contributed before to ideas

@Snooz82 Snooz82 self-assigned this Oct 6, 2024
@Snooz82 Snooz82 added this to the v18.9.0 milestone Oct 6, 2024
@Snooz82 Snooz82 changed the title Remove the "tips" on selector errors Remove the "tips" and ANSI colors on errors Oct 7, 2024
@Snooz82
Copy link
Member

Snooz82 commented Oct 7, 2024

I will also remove the ANSI colors from the Playwright error messages.

@Snooz82 Snooz82 closed this as completed Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: medium
Projects
None yet
Development

No branches or pull requests

3 participants