Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Program terminated!?!? #8

Open
RobThree opened this issue Feb 15, 2018 · 0 comments
Open

Program terminated!?!? #8

RobThree opened this issue Feb 15, 2018 · 0 comments

Comments

@RobThree
Copy link

RobThree commented Feb 15, 2018

Running ./creatDb for the first time I encountered a Program Terminated! message. I thought something was wrong. I had to go have a look at the source code only to find out that that's the message it outputs when it's done. Maybe change the message to Completed or Done or something?

Also: maybe a few lines of output during operation when a verbose flag (-v for example) is passed ("Doing X...", "Doing Y...") would be nice; that way you know something is still going on. Some output could be done in delegParser ("Parsing afrinic...", "Parsing lacnic..."), then something like "Sorting list...", then "Checking for and fixing overlaps...", .... and finally "Building ip2country.db".

eg:

$ ./createDb
Parsing afrinic
Parsing lacnic
Parsing arin
Parsing apnic
Parsing ripencc
Reading and sorting data
Checking for and fixing overlaps
Reading and sorting final version
Done!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant