Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All assertions should support assertSoftly #196

Closed
piotrb5e3 opened this issue Jun 11, 2021 · 5 comments
Closed

All assertions should support assertSoftly #196

piotrb5e3 opened this issue Jun 11, 2021 · 5 comments

Comments

@piotrb5e3
Copy link
Contributor

Hi,
Thanks to #178 Kluent now has the assertSoftly construct. It was released recently as part of 1.65.

Unfortunately, some assertions still do not support assertSoftly, as the support was only added for methods relying on assertTrue, but not for these relying on fail (eg shouldHaveSize works for subtypes of Sequence, but not Iterable).

This makes it unintuitive to use assertSoftly.

@MarkusAmshove
Copy link
Owner

Your PR #179 was released with 1.66, which should close this issue :-) Thank you for the contribution!

@piotrb5e3
Copy link
Contributor Author

I'd like to reopen this issue.
#197 was only fixing a problem that I saw when trying to add a test case for this issue. The test case added in #198 fails when added to current master.

@MarkusAmshove MarkusAmshove reopened this Jun 14, 2021
@MarkusAmshove
Copy link
Owner

Sorry for being to fast :-) The build seemed fine, aside from SonarCloud (which was an issue on my side)

@MarkusAmshove
Copy link
Owner

You can give 1.67 a try now :)

@piotrb5e3
Copy link
Contributor Author

It works well. I think we can close it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants